Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

align tts endpoint GET and POST default parameters for fast_inference branch #1210

Open
wants to merge 1 commit into
base: fast_inference_
Choose a base branch
from
Open

align tts endpoint GET and POST default parameters for fast_inference branch #1210

wants to merge 1 commit into from

Conversation

SetoKaiba
Copy link
Contributor

align tts endpoint GET and POST default parameters

@SetoKaiba SetoKaiba changed the title align tts endpoint GET and POST default parameters align tts endpoint GET and POST default parameters for fast_inference branch Jun 20, 2024
@RVC-Boss
Copy link
Owner

@ChasonJiang

@SetoKaiba
Copy link
Contributor Author

@KevinZhang19870314 @ChasonJiang What about this PR? Let me clarify why I have to modify like this.

  • First of all, I think that the behaviour between GET and POST of tts endpoint should be the same.
  • Secondly, tts_infer_yaml_path is specified as optional. For the GET original implmentation, it uses the default "GPT_SoVITS/configs/tts_infer.yaml" value of tts_infer_yaml_path. But for the POST original implmentation, it uses the default None value of tts_infer_yaml_path parameter. Then it will create a default config yaml and overwrite the original one. I think that it's a bug.

I'm not sure the understanding and my fix is correct. Please review this PR. Thank you.

@ChasonJiang
Copy link
Contributor

Thank you for your correction. I think it is very good, but the final decision is up to him. @RVC-Boss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SetoKaiba @RVC-Boss @ChasonJiang